From 0f1b7d9d800c3405701b5e57913b63c0cb30b6c4 Mon Sep 17 00:00:00 2001 From: Peter Harrison Date: Mon, 27 Mar 2023 20:30:23 -0700 Subject: [PATCH] Test 1679974223 --- .github/PR_REVIEW_PROCESS.md | 30 ----------------- .github/workflows/pull-request-target.yaml | 38 ++++++++++++++++++---- 2 files changed, 31 insertions(+), 37 deletions(-) delete mode 100644 .github/PR_REVIEW_PROCESS.md diff --git a/.github/PR_REVIEW_PROCESS.md b/.github/PR_REVIEW_PROCESS.md deleted file mode 100644 index 2c9ebdb3..00000000 --- a/.github/PR_REVIEW_PROCESS.md +++ /dev/null @@ -1,30 +0,0 @@ -## Our Pull Request Approval Process. - -We have these basic policies to make the approval process smoother for our volunteer team. - -### Testing Your Code - -Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur: - -1. The overall code coverage drops below the target threshold of the repository -2. Any file in the pull request has code coverage levels below the repository threshold - -The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. - -### Reviewers - -When your PR has been assigned reviewers contact them to get your code reviewed and approved via: - -1. comments in this PR or -1. our slack channel - -#### Reviewing Your Code - -Your reviewer(s) will have the following roles: - -1. arbitrators of future discussions with other contributors about the validity of your changes -2. point of contact for evaluating the validity of your work -3. person who verifies matching issues by others that should be closed. -4. person who gives general guidance in fixing your tests - -:dart: Contacting the person who assigned the mentors is not advised unless they make a request. Do not @ the person who did the assignment otherwise. diff --git a/.github/workflows/pull-request-target.yaml b/.github/workflows/pull-request-target.yaml index 653ebf35..9b2f5992 100644 --- a/.github/workflows/pull-request-target.yaml +++ b/.github/workflows/pull-request-target.yaml @@ -18,14 +18,38 @@ jobs: name: Pull Request Target runs-on: ubuntu-latest steps: - - name: Checkout repo to get root directory variable - uses: actions/checkout@v3 - - name: Dump GitHub context - env: - GITHUB_CONTEXT: ${{ toJSON(github) }} - run: echo "$GITHUB_CONTEXT" - name: Add the PR Review Policy as a comment uses: thollander/actions-comment-pull-request@v2 with: comment_tag: pr_review_policy - filePath: ${{ HOME }}/.github/PR_REVIEW_PROCESS.md + message: | + ## Our Pull Request Approval Process. + + We have these basic policies to make the approval process smoother for our volunteer team. + + ### Testing Your Code + + Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur: + + 1. The overall code coverage drops below the target threshold of the repository + 2. Any file in the pull request has code coverage levels below the repository threshold + + The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. + + ### Reviewers + + When your PR has been assigned reviewers contact them to get your code reviewed and approved via: + + 1. comments in this PR or + 1. our slack channel + + #### Reviewing Your Code + + Your reviewer(s) will have the following roles: + + 1. arbitrators of future discussions with other contributors about the validity of your changes + 2. point of contact for evaluating the validity of your work + 3. person who verifies matching issues by others that should be closed. + 4. person who gives general guidance in fixing your tests + + :dart: Contacting the person who assigned the mentors is not advised unless they make a request. Do not @ the person who did the assignment otherwise.