Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: migrate the file 'test/graphql/types/Mutation/createChatMembership.test.ts' to integration test #3272

Open
Piyushk8 opened this issue Feb 22, 2025 · 12 comments
Assignees
Labels
bug Something isn't working GSoC Priority security Security fix test Testing application

Comments

@Piyushk8
Copy link

Describe the bug

The createChatMembership GraphQL mutation (in test/graphql/types/Mutation/createChatMembership.test.ts) uses mocked tests, contradicting the project's requirement for integration testing via real API calls for all mutations in that directory. These mutation files are also incorrectly located; they belong in test/routes/Graphql/Mutation/*.

Expected Behavior

All GraphQL mutations, including createChatMembership, should be thoroughly integration tested using actual API calls. Mutation files should reside in test/routes/Graphql/Mutation/*.

Actual Behavior

createChatMembership uses mocked tests, bypassing the real API and services. The file is in the wrong directory.

Impact

Mocked tests provide a false sense of security, risking undetected bugs and regressions. Inconsistent testing hinders maintainability.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Piyushk8 Piyushk8 added the bug Something isn't working label Feb 22, 2025
@github-actions github-actions bot added security Security fix test Testing application unapproved Unapproved for Pull Request labels Feb 22, 2025
@iamanishx
Copy link

@palisadoes please assign as one of my PR is ready for review

@Cioppolo14
Copy link
Contributor

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too. @iamanishx

@gurramkarthiknetha
Copy link

@palisadoes @Cioppolo14 i want to work on this issue could you please assign this issue

@palisadoes
Copy link
Contributor

@gurramkarthiknetha

You have been closing too many PRs prematurely recently. Finish the one PR you are working on before asking to be assigned to more issues.

Image

@Vinod-Mane3021
Copy link

Can i work on this issue

@gurramkarthiknetha
Copy link

@gurramkarthiknetha

You have been closing too many PRs prematurely recently. Finish the one PR you are working on before asking to be assigned to more issues.

Image

Got it! I'll make sure to focus on my current PR and ensure it's complete before opening new ones. Thanks for the feedback!

@bandhan-majumder
Copy link

please assign @palisadoes

@gurramkarthiknetha
Copy link

@gurramkarthiknetha

You have been closing too many PRs prematurely recently. Finish the one PR you are working on before asking to be assigned to more issues.

Image

@palisadoes sir ,
now my pr is merged and i don't have any issues right now could you please assign it to me

@anuragnegi000
Copy link

i would like to work on this issue

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Feb 28, 2025
Copy link

github-actions bot commented Mar 8, 2025

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 8, 2025
@Cioppolo14
Copy link
Contributor

Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@DarkFalc0n
Copy link

Can I please be assigned to this issue? I would like to work on this.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GSoC Priority security Security fix test Testing application
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

9 participants