-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMongo: migrate the file 'test/graphql/types/Mutation/createChatMembership.test.ts' to integration test #3272
Comments
@palisadoes please assign as one of my PR is ready for review |
Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too. @iamanishx |
@palisadoes @Cioppolo14 i want to work on this issue could you please assign this issue |
You have been closing too many PRs prematurely recently. Finish the one PR you are working on before asking to be assigned to more issues. |
Can i work on this issue |
Got it! I'll make sure to focus on my current PR and ensure it's complete before opening new ones. Thanks for the feedback! |
please assign @palisadoes |
@palisadoes sir , |
i would like to work on this issue |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue. |
Can I please be assigned to this issue? I would like to work on this. |
Describe the bug
The
createChatMembership
GraphQL mutation (intest/graphql/types/Mutation/createChatMembership.test.ts
) uses mocked tests, contradicting the project's requirement for integration testing via real API calls for all mutations in that directory. These mutation files are also incorrectly located; they belong intest/routes/Graphql/Mutation/*
.Expected Behavior
All GraphQL mutations, including
createChatMembership
, should be thoroughly integration tested using actual API calls. Mutation files should reside intest/routes/Graphql/Mutation/*
.Actual Behavior
createChatMembership
uses mocked tests, bypassing the real API and services. The file is in the wrong directory.Impact
Mocked tests provide a false sense of security, risking undetected bugs and regressions. Inconsistent testing hinders maintainability.
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: