Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): update scripts and delete useless files #512

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 20, 2024 12:38
Copy link

ti-chi-bot bot commented Dec 20, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the following key changes have been made:

  • The gen-delivery-image-commands.ts script has been updated to use the jsr:@std/yaml@1.0.5 module instead of https://deno.land/std@0.214.0/yaml/mod.ts. Also, the script has been updated to use the jsr:@std/cli@1.0.9 module instead of https://deno.land/std@0.194.0/flags/mod.ts. In addition, the shebang line has been updated to use deno and allow read and write permissions.
  • The gen-delivery-images-with-config.sh script has been deleted.

As for potential problems, there are no obvious issues with the changes. However, it is always a good practice to test the changes locally before merging them into the main code base.

Regarding suggestions for fixing, the changes seem to be straightforward and do not require any further fixing. However, it would be good to update the pull request description to provide more information about the changes and their purpose, as the current description is very brief and does not explain much.

@ti-chi-bot ti-chi-bot bot added the size/M label Dec 20, 2024
Copy link
Contributor Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit bdea14a into main Dec 20, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/update-script branch December 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant