fix(tidb,pd): remove race flag for failpoint target

[wuhuizuo]

The failpoint target will only be used in testing env, I agreed with the testing team: agreed to remove the race option.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems the key change is removing the WITH_RACE flag from the failpoint target in the packages.yaml.tmpl file. The diff shows that the flag is removed from both components of the failpoint target in the file.

As for potential problems, it's hard to say without more context. However, if the WITH_RACE flag was added intentionally to enable race detection in the code, then removing it could potentially lead to undetected race conditions in the future.

To address this, the PR author should explain in the description why the WITH_RACE flag is being removed and confirm that it's not needed for race detection. If race detection is still needed, then the PR author should explain how it will be performed without the WITH_RACE flag.

Assuming there are no issues with the removal of the WITH_RACE flag, my suggestion for fixing this PR would be to add a comment in the packages.yaml.tmpl file explaining why the flag was removed and confirming that it's not needed for race detection. For example, the comment could say something like:

# Removed WITH_RACE flag from failpoint target as it's not needed for race detection

[wuhuizuo]

/review default

[ti-chi-bot]

@wuhuizuo:

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to removing the race option in the failpoint target, which is only used in the testing environment.

The actual code changes are located in the packages.yaml.tmpl file, where the WITH_RACE flag has been removed from the failpoint target.

Potential problems:

• It is not clear why the WITH_RACE flag was added in the first place. If it was added to solve a specific problem, removing it may cause issues in the future.
• It is not specified which testing team agreed to remove the race flag. If this decision was made without proper consultation, it may cause confusion among team members.

Fixing suggestions:

• If the WITH_RACE flag was added to solve a specific problem, it would be helpful to include a brief explanation in the pull request description.
• To avoid confusion, it would be good to specify which testing team made the decision to remove the race flag. Additionally, it would be helpful to explain why this decision was made.

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wuhuizuo]

/cc @stevenayu

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment