-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ticdc): fix builder image #540
Conversation
- add gcc into rocky linux based builder image - fix skaffold-centos7.yaml file Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Based on the Pull Request title and description, it appears that the changes are related to the builder image for the
These changes seem reasonable and necessary. However, there are a few potential issues that should be addressed:
Here are some suggestions for addressing these issues:
Overall, the changes seem reasonable and necessary, but it is important to address these potential issues before merging the Pull Request. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Based on the pull request title and description, the key changes are:
There are no potential problems that can be identified from the pull request. However, some suggestions for improvement are:
|
Signed-off-by: wuhuizuo wuhuizuo@126.com