-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for executing regular actions #319
Comments
I propose two possible solutions 1 - Simple hacky one. Convert Actions to DurativeActions, something like: auto action = domain_client_->getAction(
get_action_name(plan_item.action), get_action_params(plan_item.action));
plansys2_msgs::msg::DurativeAction::SharedPtr durative_action;
durative_action->name = action->name;
durative_action->over_all_requirements = action->preconditions;
durative_action->at_end_effects = action->effects; Then everywhere in the action execution pipeline where 2 - In struct ActionExecutionInfo
{
std::shared_ptr<ActionExecutor> action_executor = {nullptr};
bool at_start_effects_applied = {false};
bool at_end_effects_applied = {false};
rclcpp::Time at_start_effects_applied_time;
rclcpp::Time at_end_effects_applied_time;
std::variant<std::shared_ptr<plansys2_msgs::msg::Action>, std::shared_ptr<plansys2_msgs::msg::DurativeAction>> action_info = {nullptr};
std::string execution_error_info;
double duration;
double duration_overrun_percentage = -1.0;
}; Then everywhere in the action execution pipeline where |
It would be interesting to be able to execute regular actions (non durative-action).
Right now, the following error occurs when trying to execute regular actions:
If I understood correctly, this error comes from:
ros2_planning_system/plansys2_executor/src/plansys2_executor/ExecutorNode.cpp
Lines 375 to 376 in a797196
I am not sure what is the best way to implement this feature.
Extend the ActionExecutionInfo struct to support regular actions then check whether the action is a regular or durative action when constructing the action map?
Related to #317
The text was updated successfully, but these errors were encountered: