Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dommaschk Potential Issues #1467

Open
2 of 6 tasks
dpanici opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1496
Open
2 of 6 tasks

Dommaschk Potential Issues #1467

dpanici opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1496
Assignees
Labels
P2 Medium Priority, not urgent but should be on the near-term agend

Comments

@dpanici
Copy link
Collaborator

dpanici commented Dec 13, 2024

It seems that for certain Dommaschk potentials, the results do not align with past publications.

Examples are in this paper, HELIOTRON-E apparently gives some surfaces but with helical excursion which is incorrect, and the other two give no flux surfaces at all.

Things to check

  • Implement the HELIOTRON-E myself and check - seems to have a helical axis when it should be planar
  • check AD B versus finite difference B for different step sizes (maybe I did not do the gradient right, though I doubt it)
  • Implement optimization with the potentials to see if that helps uncover any issues (if this does not work at all maybe there are some issues numerically with implementation?)
  • look at algorithm closer and compare to how Dommaschk originally implemented them, see if there are parts prone to numerical error (in orig. paper, he mentions that the factorial can cause very large denominators for some terms)
    • could try implementing with a higher precision library (mpmath or sympy maybe) to see if it is precision issues, I have them in Sympy somewhere already I think
    • implement recursive version of the potentials (currently have nonrecursive implemented)
@dpanici dpanici added the P2 Medium Priority, not urgent but should be on the near-term agend label Dec 13, 2024
@dpanici dpanici self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium Priority, not urgent but should be on the near-term agend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant