Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI to work with new pressio-ops repository #691

Closed
cwschilly opened this issue Sep 27, 2024 · 0 comments · Fixed by #690
Closed

Fix CI to work with new pressio-ops repository #691

cwschilly opened this issue Sep 27, 2024 · 0 comments · Fixed by #690

Comments

@cwschilly
Copy link
Collaborator

cwschilly commented Sep 27, 2024 •
edited
Loading

Follow on to #676

The CI fails on PR #690 because we can only pull in pressio-ops by default when building Pressio.

For the include-only tests, we'll need to change the CI so that it clones the pressio-ops repo and points to the include directory (similar to what we do with eigen.
@cwschilly cwschilly mentioned this issue Sep 27, 2024
Merged
cwschilly added a commit that referenced this issue Oct 1, 2024
@cwschilly
#691: clone and include pressio-ops in CI
9451741
cwschilly added a commit that referenced this issue Oct 1, 2024
@cwschilly
#691: add debugging prints
ae37ce0
cwschilly added a commit that referenced this issue Oct 1, 2024
@cwschilly
#691: include pressio-ops on embedded definitions test as well
ed9fcf4
cwschilly added a commit that referenced this issue Oct 1, 2024
@cwschilly
#691: clone and include pressio-ops in CI
1c55f7b
@fnrizzi fnrizzi added this to pressio Oct 14, 2024
@fnrizzi fnrizzi moved this to In Progress in pressio Oct 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in pressio Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
pressio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#676: evaluate simplifying things with pressio-ops Pressio/pressio
1 participant
@cwschilly