Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event don't render in the rigth order for table en chapter #23

Open
gabrielaillet opened this issue Jul 3, 2023 · 2 comments
Open

Event don't render in the rigth order for table en chapter #23

gabrielaillet opened this issue Jul 3, 2023 · 2 comments
Labels
bug Something isn't working USFM Parser Issue

Comments

@gabrielaillet
Copy link
Collaborator

image

This is the order of call of event with proskomma and the blockResult.items for the function renderContent()

\id XXD - World English Bible
\h Bible reading plan
\toc1 Bible reading plan
\mt1 Daily Bible reading plan
\c 1
\cp January
\s January
\b
\tr \tc1 date \tc2 Scripture
\tr \tc1 1 \tc2 \xt Genesis 1–2; Matthew 1:1–2:12; Psalm 1; Proverbs 1:1-6\xt*
\c 2
\cp February
\s February
\b

this is the usfm used for the example.

for reference this is what blockResult.items looks like just afeter the end of the xt :
[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'span/xt'
}
[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'pubChapter/January'
}
[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'chapter/1'
}

[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'table'
}
[Object: null prototype] {
type: 'token',
subType: 'wordLike',
payload: 'February'
}
[Object: null prototype] {
type: 'scope',
subType: 'start',
payload: 'chapter/2'
}

[Object: null prototype] {
type: 'scope',
subType: 'start',
payload: 'pubChapter/February'
}
[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'cell/body/left/1'
}
ici
[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'pubChapter/February'
}
[Object: null prototype] {
type: 'scope',
subType: 'end',
payload: 'chapter/2'
}

@gabrielaillet
Copy link
Collaborator Author

this issue is present in the branch MajTabRendeRerXschema0_4_0

@monday-com-github monday-com-github bot changed the title Event don't render in the rigth order for table en chapter Event don't render in the rigth order for table en chapter Jan 8, 2024
@mvahowe mvahowe added the bug Something isn't working label Jan 10, 2024
@chrisvire
Copy link

We have a book like this (I have removed table rows and only included 2 months to make it shorter):

\id XXD
\h Leer el Nuevo Testamento
\toc1 Leer el Nuevo Testamento
\mt1 Leer el Nuevo Testamento diariamente
\c 1
\cp Enero
\s Enero
\tr \tc1 fecha \tc2 selección
\tr \tc1 1 \tc2 \xt Mateo 1.1–2.12\xt*
\tr \tc1 2 \tc2 \xt Mateo 2.13–3.6\xt*
\tr \tc1 3 \tc2 \xt Mateo 3.7–4.11\xt*
\tr \tc1 4 \tc2 \xt Mateo 4.12-25\xt*
\c 2
\cp Febrerp
\s Febrero
\tr \tc1 fecha \tc2 selección
\tr \tc1 1 \tc2 \xt Mateo 21.23-46\xt*
\tr \tc1 2 \tc2 \xt Mateo 22.1-33\xt*
\tr \tc1 3 \tc2 \xt Mateo 22.34–23.12\xt*
\tr \tc1 4 \tc2 \xt Mateo 23.13-39\xt*

When we request chapter one from this book, we all of the events for the whole book except that the chapter events come at the end.

We have hacked our book conversion code to insert \p at the beginning and end of the tables. Then we get just one chapter at a time.
sillsdev/appbuilder-pwa#786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working USFM Parser Issue
Projects
None yet
Development

No branches or pull requests

3 participants