From 207c92def0497b78cd8987562da93a2e4cb2162a Mon Sep 17 00:00:00 2001 From: nickshulman Date: Sat, 22 Feb 2025 19:48:22 -0800 Subject: [PATCH] Catch exceptions copying from AlertDlg (#3367) Fixed unhandled error pressing copy button on message box when another application has the clipboard locked (reported by Brendan) AlertDlg now uses ClipboardHelper to catch clipboard locked exceptions. This got broken when CommonAlertDlg base class was created in CommonUtil. "CommonAlertDlg.CopyMessage" was supposed to be overridden for Skyline's extra error handling. --- pwiz_tools/Skyline/Alerts/AlertDlg.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pwiz_tools/Skyline/Alerts/AlertDlg.cs b/pwiz_tools/Skyline/Alerts/AlertDlg.cs index 1d5b70b0c5..4506186a90 100644 --- a/pwiz_tools/Skyline/Alerts/AlertDlg.cs +++ b/pwiz_tools/Skyline/Alerts/AlertDlg.cs @@ -96,5 +96,9 @@ protected override void OnLoad(EventArgs e) base.OnLoad(e); GetModeUIHelper().OnLoad(this); } + public override void CopyMessage() + { + ClipboardHelper.SetSystemClipboardText(this, GetTitleAndMessageDetail()); + } } }