Skyline: Raised the peak truncation threshold #3361
Conversation
The TransitionResults.Truncated and PrecursorResults.CountTruncated values have been reported as too sensitive for a while, especially for the Stellar which is often tuned to use very narrow retention time windows for scheduled data acquisition. These values are based on a height proportion threshold currently set to 0.01 or 1%. In the initial commit the value is set to 0.25 of 25%, i.e. quarter-max where 50% is half-max.
- add TruncatedProportion to TransitionGroupChromInfo.Equals() and GetHashCode()
| @@ -116,6 +116,8 @@ public double? RatioDotProduct { | |||
| public double? AverageMassErrorPPM { get { return ChromInfo.MassError; } } | |||
| [Format(NullValue = TextUtil.EXCEL_NA)] | |||
| public int? CountTruncated { get { return ChromInfo.Truncated; } } | |||
| [Format(Formats.STANDARD_RATIO, NullValue = TextUtil.EXCEL_NA)] | |||
There was a problem hiding this comment.
We might want to use Formats.Percent here instead of Formats.STANDARD_RATIO.
(There is also Formats.PEAK_AREA_NORMALIZED which is a percent with up to four decimal places)
Should we also do this for PrecursorResults.AverageMassErrorPPM? I was following that as an example. Seems like the two have very similar calculation overhead. Or do we need to have that in Panorama? It is worth remembering that anything not in the .sky file will generally not be available in Panorama by default, unless a user goes through the pain of creating a calculate annotation and forcing it back into the XML. This has very low impact on the XML since I made it only get written when the truncation count is non-zero. |
Calculate ProportionTruncated on demand in PrecursorResult instead of storing it on TransitionGroupChromInfo.
|
This PR fails "TestDiaQeFullSearchTutorialExtra". I will update the expected numbers so that it passes. |
The TransitionResults.Truncated and PrecursorResults.CountTruncated values have been reported as too sensitive for a while, especially for the Stellar which is often tuned to use very narrow retention time windows for scheduled data acquisition. These values are based on a height proportion threshold currently set to 0.01 or 1%. In the initial commit the value is set to 0.25 of 25%, i.e. quarter-max where 50% is half-max.