From 9584b03e9f60443982d89d5b1defda313c07bc47 Mon Sep 17 00:00:00 2001 From: Brian Pratt Date: Mon, 24 Feb 2025 12:39:50 -0800 Subject: [PATCH] Fix for previous attempt to avoid launching parallel test nodes when they aren't needed - even with a single test, if multiple languages are selected then parallel can be useful --- pwiz_tools/Skyline/SkylineTester/TabTests.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pwiz_tools/Skyline/SkylineTester/TabTests.cs b/pwiz_tools/Skyline/SkylineTester/TabTests.cs index 8155c12368..c836af0601 100644 --- a/pwiz_tools/Skyline/SkylineTester/TabTests.cs +++ b/pwiz_tools/Skyline/SkylineTester/TabTests.cs @@ -107,7 +107,8 @@ public override bool Run() if (GetTestList().Length > 0) args.Append(" perftests=on"); // In case any perf tests were explicitly selected - no harm if they weren't - if (MainWindow.RunParallel.Checked && GetTestCount() > 1) // No need for parallel on a single test + if (MainWindow.RunParallel.Checked && + GetTestCount()*cultures.Count > 1) // No need to fire up parallel nodes on a single test in single culture { // CONSIDER: Should we add a checkbox for this? // args.Append(" keepworkerlogs=1"); // For debugging startup issues. Look for TestRunner-docker-worker_#-docker.log files in pwiz root