feature/134-cart-layout Cart layout #134 #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial blocking in of the cart layout and wiring up of the data
Update the Cart layout to match the comp and implement the quantity change and remove item features
Open
|
|
theBRiGuy
reviewed
Mar 13, 2020
| <div class="cart-items" data-template="cart-items"> | ||
| <h2 class="heading heading--section">Items in Cart</h2> |
There was a problem hiding this comment.
As per BEM, should this be .cart-items__heading?
There was a problem hiding this comment.
There are other places it was used like this so I just copied and pasted
like in
cart-moneyBox.hbs
product-sort.hbs
product-filter.hbs
Do you still want me to changes?
if yes
is this ok?
<h2 class="cart-items__heading heading--section">Items in Cart</h2>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Cart layout to match the comp and implement the quantity change and remove item features