From 7c7771d52cd1c903081f524493c93626c6d6915f Mon Sep 17 00:00:00 2001 From: Aditya Goel Date: Tue, 16 Jul 2024 19:21:40 +0100 Subject: [PATCH] Run CI more regularly --- .github/workflows/ci.yml | 6 +----- ndonnx/_funcs.py | 4 ---- ndonnx/notes.txt | 3 --- 3 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 ndonnx/notes.txt diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 971c461..e4364a2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,9 +1,5 @@ name: CI -on: - push: - branches: - - main - pull_request: +on: [push, pull_request] concurrency: group: ${{ github.workflow }}-${{ github.ref }} diff --git a/ndonnx/_funcs.py b/ndonnx/_funcs.py index b61b7c1..bb8dab7 100644 --- a/ndonnx/_funcs.py +++ b/ndonnx/_funcs.py @@ -281,10 +281,6 @@ def result_type( *objects: dtypes.CoreType | dtypes.StructType | Array, ) -> dtypes.CoreType | dtypes.StructType: observed_dtypes = {obj.dtype if isinstance(obj, Array) else obj for obj in objects} - - if len(observed_dtypes) == 1: - return next(iter(observed_dtypes)) - nullable = False np_dtypes = [] for dtype in observed_dtypes: diff --git a/ndonnx/notes.txt b/ndonnx/notes.txt deleted file mode 100644 index bc331c4..0000000 --- a/ndonnx/notes.txt +++ /dev/null @@ -1,3 +0,0 @@ -1. binary ops with core types and udts raise exception -2. __getattr__ exposes fields - probably shouldn't -3. _fields method in array