Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pydantic 2 secrets for PRIMARY_STORE quacc setting #1023

Open
Andrew-S-Rosen opened this issue Oct 5, 2023 · 0 comments
Open

Use Pydantic 2 secrets for PRIMARY_STORE quacc setting #1023

Andrew-S-Rosen opened this issue Oct 5, 2023 · 0 comments
Labels
enhancement New feature or request good-first-issue

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Oct 5, 2023 •
edited
Loading

What new feature would you like to see?

Currently, the `PRIMARY_STORE' quacc setting is stored in the default quacc YAML file. But this isn't ideal because we should keep secrets (eg credentials) elsewhere. Pydantic 2, via pydantic-settings, now supports secret management. We should use that instead.

The same issue exists in materialsproject/jobflow#451.
@Andrew-S-Rosen Andrew-S-Rosen changed the title Use Pydantic 2 secrets for PRIMARY_STORE Use Pydantic 2 secrets for PRIMARY_STORE quacc setting Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andrew-S-Rosen