Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Applying license outside the source set #10

Open
bric3 opened this issue Jun 23, 2023 · 2 comments
Open

Applying license outside the source set #10

bric3 opened this issue Jun 23, 2023 · 2 comments

Comments

@bric3
Copy link

bric3 commented Jun 23, 2023

Currently the plugin works by looking at the module source set

for (var javaDir : this.sourceSet.getAllSource().matching(this.patternFilterable)) {

However if files leaves for any reasons outside the sourceset, they are not processed.

For example applying the header to gradle build scripts. Or to XML or YAML files that are not strictly part of a gradle project.

It might be nice to support that.

@LambdAurora
Copy link
Contributor

I have concerns over applying headers to build scripts automatically as it's kind of "modify the file that's currently defining how things are run", it's kind of like a recursion and I'm not entirely sure about it.

And for XML/YAML files, at the moment the plugin is not able to deal with those files either, and I do wonder what need is there to apply licenses to such files.

@bric3
Copy link
Author

bric3 commented Jun 23, 2023

I have concerns over applying headers to build scripts automatically as it's kind of "modify the file that's currently defining how things are run", it's kind of like a recursion and I'm not entirely sure about it.

Build scripts are not just jitted, Gradle will compile them and configure them before. So it safe to perform this. Especially since it's "only" prepending comment.

And for XML/YAML files, at the moment the plugin is not able to deal with those files either, and I do wonder what need is there to apply licenses to such files.

Indeed, that's an issue right now (#11), but if such file format get supported this could be useful.

@bric3 bric3 changed the title Apllying license outside the source set Applying license outside the source set Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants