From e0d0a910d80836269f5891f083634e97b71f84a2 Mon Sep 17 00:00:00 2001 From: Anish Pawaskar Date: Thu, 11 Jan 2024 03:56:54 +0530 Subject: [PATCH 1/2] fix response and write test --- src/utils/formatTask.ts | 5 ++++- tests/unit/utils/formatTask.test.ts | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/utils/formatTask.ts b/src/utils/formatTask.ts index 9ee68829..4a58ac8b 100644 --- a/src/utils/formatTask.ts +++ b/src/utils/formatTask.ts @@ -21,7 +21,10 @@ export function generateTaskResponseMessage( formattedTasks: string[], status: string ) { - const title = `## ${formatStatusToTitleCase(status)} Tasks of ${nickName}`; + const title = + formattedTasks.length !== 0 + ? `## ${formatStatusToTitleCase(status)} Tasks of ${nickName}` + : `## ${nickName} doesn't have any in-progress task`; const tasks = formattedTasks.join("\n\n"); const allTaskLink = `[→ All Tasks](${RDS_STATUS_SITE_URL}/tasks?q=status:all+assignee:${nickName}) `; diff --git a/tests/unit/utils/formatTask.test.ts b/tests/unit/utils/formatTask.test.ts index 22dfa2c9..b10f6b0f 100644 --- a/tests/unit/utils/formatTask.test.ts +++ b/tests/unit/utils/formatTask.test.ts @@ -37,6 +37,7 @@ describe("Test generateTaskResponseMessage function", () => { it("Should return a string with task details", () => { const formattedTasks = tasks.tasks.map((task: task) => formatTask(task)); + console.log("format task frm fail", formattedTasks.length); const responseMessage = generateTaskResponseMessage( "sunny-s", formattedTasks, @@ -64,4 +65,18 @@ describe("Test generateTaskResponseMessage function", () => { const expectedResponseMessage = `${expectedMessage}\n${task1}\n\n${task2}\n${allTaskURL}\n`; expect(responseMessage).toBe(expectedResponseMessage); }); + + it("should return a string if user don't have any in-progress task", () => { + const formattedTasks: [] = []; + console.log("format task frm fail", formattedTasks.length); + const responseMessage = generateTaskResponseMessage( + "anish-pawaskar", + formattedTasks, + "IN_PROGRESS" + ); + const expectedMessage = `## anish-pawaskar doesn't have any in-progress task`; + const allTaskURL = `[→ All Tasks](https://status.realdevsquad.com/tasks?q=status:all+assignee:anish-pawaskar)`; + const expectedResponseMessage = `${expectedMessage}\n\n${allTaskURL}\n`; + expect(responseMessage).toBe(expectedResponseMessage); + }); }); From 7b98fea1293c8f76068075380d74c23386a49f25 Mon Sep 17 00:00:00 2001 From: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Date: Thu, 11 Jan 2024 04:25:58 +0530 Subject: [PATCH 2/2] Update formatTask.test.ts --- tests/unit/utils/formatTask.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/unit/utils/formatTask.test.ts b/tests/unit/utils/formatTask.test.ts index b10f6b0f..1182aa88 100644 --- a/tests/unit/utils/formatTask.test.ts +++ b/tests/unit/utils/formatTask.test.ts @@ -37,7 +37,6 @@ describe("Test generateTaskResponseMessage function", () => { it("Should return a string with task details", () => { const formattedTasks = tasks.tasks.map((task: task) => formatTask(task)); - console.log("format task frm fail", formattedTasks.length); const responseMessage = generateTaskResponseMessage( "sunny-s", formattedTasks,