Make output console work again #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a last processed index for adding new message that we didn't add yet, so we can keep the folded output items.
|
Will merge this as it's fixing the output console again. We can revisit this later when we are adding support for collab. We could then also implement a limit of events/entries shown inside the console. |
|
Great work!! Hopefully I can get the variable list working by Monday, I have some other things I need to finish first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a last processed index for adding new messages to the editor, that we didn't add yet. By doing this, we can keep the folded/unfolded entries when we receive a new output event. So we don't unfold or fold an entry when the user changed this state, that would be a boomer.