Push new resolvers and suggestion factories to the beginning to give them priority

Author: Revxrsal

common/src/main/java/revxrsal/commands/core/BaseAutoCompleter.java

@@ -21,7 +21,7 @@ final class BaseAutoCompleter implements AutoCompleter {
 
     private final BaseCommandHandler handler;
     final Map<String, SuggestionProvider> suggestionKeys = new HashMap<>();
-    final List<SuggestionProviderFactory> factories = new ArrayList<>();
+    final LinkedList<SuggestionProviderFactory> factories = new LinkedList<>();
 
     public BaseAutoCompleter(BaseCommandHandler handler) {
         this.handler = handler;
@@ -54,10 +54,10 @@ public BaseAutoCompleter(BaseCommandHandler handler) {
     @Override public AutoCompleter registerParameterSuggestions(@NotNull Class<?> parameterType, @NotNull SuggestionProvider provider) {
         notNull(parameterType, "parameter type");
         notNull(provider, "provider");
-        factories.add(SuggestionProviderFactory.forType(parameterType, provider));
+        registerSuggestionFactory(SuggestionProviderFactory.forType(parameterType, provider));
         Class<?> wrapped = Primitives.wrap(parameterType);
         if (wrapped != parameterType) {
-            factories.add(SuggestionProviderFactory.forType(wrapped, provider));
+            registerSuggestionFactory(SuggestionProviderFactory.forType(wrapped, provider));
         }
         return this;
     }
@@ -75,7 +75,7 @@ public BaseAutoCompleter(BaseCommandHandler handler) {
 
     @Override public AutoCompleter registerSuggestionFactory(@NotNull SuggestionProviderFactory factory) {
         notNull(factory, "suggestion provider factory cannot be null!");
-        factories.add(0, factory);
+        factories.push(factory);
         return this;
     }
 

common/src/main/java/revxrsal/commands/core/BaseCommandHandler.java

@@ -42,7 +42,7 @@ public class BaseCommandHandler implements CommandHandler {
     protected final Map<CommandPath, BaseCommandCategory> categories = new HashMap<>();
     private final BaseCommandDispatcher dispatcher = new BaseCommandDispatcher(this);
 
-    final List<ResolverFactory> factories = new ArrayList<>();
+    final LinkedList<ResolverFactory> factories = new LinkedList<>();
     final BaseAutoCompleter autoCompleter = new BaseAutoCompleter(this);
     final ClassMap<List<ParameterValidator<Object>>> validators = new ClassMap<>();
     final ClassMap<ResponseHandler<?>> responseHandlers = new ClassMap<>();
@@ -215,14 +215,14 @@ public BaseCommandHandler() {
         notNull(resolver, "resolver");
         if (type.isPrimitive())
             registerValueResolver(Primitives.wrap(type), resolver);
-        factories.add(new ResolverFactory(ValueResolverFactory.forType(type, resolver)));
+        factories.push(new ResolverFactory(ValueResolverFactory.forType(type, resolver)));
         return this;
     }
 
     @Override public <T> @NotNull CommandHandler registerContextResolver(@NotNull Class<T> type, @NotNull ContextResolver<T> resolver) {
         notNull(type, "type");
         notNull(resolver, "resolver");
-        factories.add(new ResolverFactory(ContextResolverFactory.forType(type, resolver)));
+        factories.push(new ResolverFactory(ContextResolverFactory.forType(type, resolver)));
         return this;
     }
 
@@ -232,13 +232,13 @@ public BaseCommandHandler() {
 
     @Override public @NotNull CommandHandler registerValueResolverFactory(@NotNull ValueResolverFactory factory) {
         notNull(factory, "value resolver factory");
-        factories.add(new ResolverFactory(factory));
+        factories.push(new ResolverFactory(factory));
         return this;
     }
 
     @Override public @NotNull CommandHandler registerContextResolverFactory(@NotNull ContextResolverFactory factory) {
         notNull(factory, "context resolver factory");
-        factories.add(new ResolverFactory(factory));
+        factories.push(new ResolverFactory(factory));
         return this;
     }