Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min-size on annotation pannel #10

Open
Tracked by #9
Drilio opened this issue Feb 12, 2024 · 1 comment
Open
Tracked by #9

Set min-size on annotation pannel #10

Drilio opened this issue Feb 12, 2024 · 1 comment

Comments

@Drilio
Copy link
Collaborator

Drilio commented Feb 12, 2024

Set min-size on annotation pannel

@Drilio Drilio self-assigned this Feb 12, 2024
@Drilio Drilio mentioned this issue Feb 12, 2024
3 tasks
@Drilio
Copy link
Collaborator Author

Drilio commented Feb 15, 2024

We can set minWidth to the annot' panel because this value is hardcoded there : https://github.com/SCENE-CE/mirador-video/blob/fbee524cc22ce67c29aa21efa91b58e811c762d3/src/components/CompanionWindow.js#L122

I don't understand why it's hardcoded there because it's also set in the theme there : https://github.com/SCENE-CE/mirador-video/blob/fbee524cc22ce67c29aa21efa91b58e811c762d3/src/config/settings.js#L207

And Rnd isn't a MUI component so I can override this value with theme.

I see 3 solutions there :

  • Ask Mirador to remove the hardcoded value so it only pass with CSS.
  • Wrap CompanionWindow with a plugin so we can change this value for our annotation panel only.
  • Applies CSS rules that don't break the content but hide it instead when panel size is less than 250px.

@Drilio Drilio assigned geourjoa and unassigned Drilio Feb 15, 2024
@geourjoa geourjoa added this to the EPIC UI UX milestone Mar 11, 2024
@geourjoa geourjoa removed this from the EPIC UI UX milestone Mar 11, 2024
@geourjoa geourjoa removed their assignment Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants