Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune old base code and reorganize current code #79

Open
chrismejia opened this issue Apr 20, 2020 · 1 comment
Open

Prune old base code and reorganize current code #79

chrismejia opened this issue Apr 20, 2020 · 1 comment
Assignees
Labels
data/functions Passing data through the site design/layout Front-end layout stuff documentation Improvements or additions to documentation feature New feature or request

Comments

@chrismejia
Copy link
Contributor

chrismejia commented Apr 20, 2020

There are lots of files and components that are being built that aren't and will not be used. Among them are pages that are set up in the wrong places - this effort is to fix all this.

Handling old code that won't be used

There are two options to handle this code:

  • delete it outright
  • comment it out to pick out useful parts later

Reorganization of current code

This link from the Gatsby docs should be able to help with the organization process.

Prismic & gatsby-plugin-sharp

From the Prismic Image Optimization FAQ:

I'm using Gatsby or a static-site generator

If you keep the image URLs unchanged in your statically generated files, URLs are still loaded from the browser and you'll benefit from the image optimisation services. If you use the gatsby-plugin-sharp package though, you won't benefit from image processing as image files are locally downloaded and served from your site files folder.

@chrismejia chrismejia added feature New feature or request design/layout Front-end layout stuff labels Apr 20, 2020
@chrismejia chrismejia changed the title Prune old base code Prune old base code and reorganize current code Apr 20, 2020
chrismejia added a commit that referenced this issue Apr 21, 2020
/pages: daily-mixes.js deleted

/components: MixesPage, MixesPageMix, SingleMix deleted
/index: refs deleted
chrismejia added a commit that referenced this issue Apr 23, 2020
Deleted
- AboutPage.js
- BioSingleMix.js
- Duration.js
- InProgress.js
- MobileNewsItem.js
- Navbar.js
- all.sass
- about-page.js
- schedule.js
chrismejia added a commit that referenced this issue Jul 26, 2020
closes #7 - merged in from test/merge-deploy-to-slider
closes #73 - not possible because of sliding layout
closes #74 - not possible because of sliding layout
closes #75 - not possible because of sliding layout
update #79 - removed all /test & /hero-test-# pages
closes #98 - separate components, but will borrow main content card styling
closes #99 - passing in individual column layout string fixed this issue
closes #109 - new layout in place; needs polish
closes #112 - seems to be a browser issues and not something fixable in our code; will keep in mind
@chrismejia chrismejia added data/functions Passing data through the site documentation Improvements or additions to documentation labels Aug 17, 2020
chrismejia added a commit that referenced this issue Aug 27, 2020
updates #79
closes #8: missed commit; this has been address in Prismic
closes #9: missed commit; Mix custom type set up in Prismic
closes #47: wontfix - current BottomNav structure is clean, unlikely to feature dropdown
@chrismejia
Copy link
Contributor Author

Remember to remove lambda function re: Different functions path detected, going to use the one specified in the Netlify configuration file: 'lambda' versus '' in the Netlify UI

chrismejia added a commit that referenced this issue Sep 2, 2020
update #79 - ScheduleShowEntry refactored into SingleScheduleEntryRow
SCSS removed NewsPage.scss and ScheduleDropdown.scss
chrismejia added a commit that referenced this issue Sep 2, 2020
chrismejia added a commit that referenced this issue Sep 3, 2020
update #79 - remove mobile-date-selector
chrismejia added a commit that referenced this issue Sep 15, 2020
chrismejia added a commit that referenced this issue Oct 1, 2020
chrismejia added a commit that referenced this issue Oct 12, 2020
chrismejia added a commit that referenced this issue Oct 21, 2020
…d packages

update gatsby version, browser, config and ssr

removed react-map-gl, react-redux, redux

updates #79
chrismejia added a commit that referenced this issue Jan 25, 2021
prune: remove HeadlineBlock slice file (#79)
chrismejia added a commit that referenced this issue Jan 25, 2021
rename HomeNews to HomeFeatures
remove HomeContent component
make highlight features stack (need to make horizontal on desktop)
chrismejia added a commit that referenced this issue Jan 26, 2021
prune (#79): StickyFeature, FeatureArticleTile,
chrismejia added a commit that referenced this issue Jan 26, 2021
make LeadFeatureHero, LeadFeatureDetails
add default props to /features components
prune (#79): MainFeatureArticle-> LeadFeatureDetails
LandingPageElement
/features commented returns
HighlightFeature, StickyFeature css
chrismejia added a commit that referenced this issue Mar 1, 2021
chrismejia added a commit that referenced this issue Mar 3, 2021
chrismejia added a commit that referenced this issue Mar 9, 2021
logic simplified and moved into Blockquote slice component
chrismejia added a commit that referenced this issue Mar 23, 2021
uninstall chalk, figlet, inquirer, puppeteer
update and push tags
chrismejia added a commit that referenced this issue Apr 7, 2021
handled by SingleScheduledShowTimes and SingleScheduledShowTitling
chrismejia added a commit that referenced this issue May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data/functions Passing data through the site design/layout Front-end layout stuff documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants