Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot_d returns wrong result #1284

Open
hkaiser opened this issue Oct 8, 2020 · 1 comment
Open

dot_d returns wrong result #1284

hkaiser opened this issue Oct 8, 2020 · 1 comment

Comments

@hkaiser
Copy link
Member

hkaiser commented Oct 8, 2020

Running the following code on 4 localities returns list(30, 60) which is wrong:

define(
    test,
    size,
    block(
        define(
            array1,
            random_d(
                list(size, size)
            )
        ),
        define(
            array2,
            random_d(
                list(size, size)
            )
        ),
        define(
            v2,
            dot_d(array1, array2)
        ),
        shape(v2)
    )
)
test(60)

as it should return list(30, 30), which is the size of each of the tiles.

@hkaiser
Copy link
Member Author

hkaiser commented Oct 9, 2020

This is caused by dot_d not supporting block-tiled matrices at the moment. Matrices should be either row-tiled or column-tiled for dot_d to produce the correct result. I will add an error message diagnosing this condition for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant