From 3d913599dd05535ffe293114ba860b26b3786053 Mon Sep 17 00:00:00 2001 From: Marc Berger Date: Thu, 13 Feb 2025 17:03:12 -0800 Subject: [PATCH] fix(SHS-5980): Minor fixes from code review --- .../humsci/hs_dashboard/src/AnnouncementsManager.php | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docroot/modules/humsci/hs_dashboard/src/AnnouncementsManager.php b/docroot/modules/humsci/hs_dashboard/src/AnnouncementsManager.php index 20f3f8c23..43f8a34d6 100644 --- a/docroot/modules/humsci/hs_dashboard/src/AnnouncementsManager.php +++ b/docroot/modules/humsci/hs_dashboard/src/AnnouncementsManager.php @@ -160,7 +160,7 @@ private function parseCsv(string $csv_content): array { } // Removes empty rows. - if (empty($data[2]) && empty($data[3])) { + if (empty($data[1]) || (empty($data[2]) && empty($data[3]))) { continue; } @@ -169,7 +169,7 @@ private function parseCsv(string $csv_content): array { } if (isset($data[2])) { - $data[2] = $this->convertMarkdownLinks('' . trim($data[2]) . ''); + $data[2] = $this->convertMarkdownLinks(trim($data[2])); } if (isset($data[3])) { @@ -286,7 +286,13 @@ public function getTableRows(): array { $table_rows[] = [ 'data' => [ ['data' => $row[1]], - ['data' => ['#markup' => $row[2]]], + [ + 'data' => [ + '#markup' => $row[2], + '#prefix' => '', + '#suffix' => '', + ], + ], ['data' => ['#markup' => $row[3]]], ], ];