Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing default parameter value and wrong TODO #136

Closed
lars-reimann opened this issue May 15, 2024 · 0 comments · Fixed by #153
Closed

Missing default parameter value and wrong TODO #136

lars-reimann opened this issue May 15, 2024 · 0 comments · Fixed by #153
Assignees
Labels
bug 🪲 Something isn't working

Comments

@lars-reimann
Copy link
Member

lars-reimann commented May 15, 2024

Describe the bug

AveragePooling2DLayer has an optional parameter stride. However, the generated stubs omit the default value and instead include a TODO:

// TODO Safe-DS does not support required but name only parameter assignments.
class AveragePooling2DLayer(
    @PythonName("kernel_size") kernelSize: Int,
    stride: Int,
    padding: Int = 0
) sub _Pooling2DLayer

Seems like it breaks because of the superclass.

To Reproduce

Generate stubs for safe-ds.

Expected behavior

  • No TODO.
  • The default value should be included.

Screenshots (optional)

No response

Additional Context (optional)

No response

@lars-reimann lars-reimann added the bug 🪲 Something isn't working label May 15, 2024
@Masara Masara moved this from Backlog to In Progress in Library Analysis Jun 16, 2024
@Masara Masara linked a pull request Jun 16, 2024 that will close this issue
@Masara Masara moved this from In Progress to Ready for Review in Library Analysis Jun 16, 2024
lars-reimann added a commit that referenced this issue Jun 20, 2024
Closes #136

### Summary of Changes

Fixed a bug where negative parameter values couldn't be parsed and would
thus be ignored.

---------

Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
Co-authored-by: Lars Reimann <mail@larsreimann.com>
@github-project-automation github-project-automation bot moved this from Ready for Review to ✔️ Done in Library Analysis Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants