Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal superclass still generated #137

Closed
lars-reimann opened this issue May 15, 2024 · 0 comments · Fixed by #141
Closed

Internal superclass still generated #137

lars-reimann opened this issue May 15, 2024 · 0 comments · Fixed by #141
Assignees
Labels
bug 🪲 Something isn't working

Comments

@lars-reimann
Copy link
Member

Describe the bug

Internal superclasses should

  1. not be included in the parent type list of a class (sub),
  2. not count towards the limit of one superclass per class,
  3. push their own members to public subclasses (feat: Generate stubs for public methods of private classes which are superclasses of public classes #64).

Neither of these requirements seems to fully work yet, e.g. for the AdaBoostRegressor:

// TODO Safe-DS does not support multiple inheritance.
class AdaBoostRegressor(
    learner: Regressor? = null,
    @PythonName("maximum_number_of_learners") maximumNumberOfLearners: Int = 50,
    @PythonName("learning_rate") learningRate: Float = 1.0
) sub Regressor, _AdaBoostBase {
    /**
     * The base learner used for training the ensemble.
     */
    attr learner: Regressor?
}
  1. _AdaBoostBase should not appear
  2. The TODO should not appear
  3. The members of _AdaBoostBase should appear in AdaBoostRegressor.

To Reproduce

Generate stubs for safe-ds.

Expected behavior

See description.

Screenshots (optional)

No response

Additional Context (optional)

No response

@lars-reimann lars-reimann added the bug 🪲 Something isn't working label May 15, 2024
@Masara Masara moved this from Backlog to In Progress in Library Analysis May 21, 2024
@Masara Masara linked a pull request May 22, 2024 that will close this issue
@Masara Masara moved this from In Progress to Ready for Review in Library Analysis Jun 15, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to ✔️ Done in Library Analysis Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants