Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't allow for any updating of entities (only creating or retrieving) #23

Open
thomasyu888 opened this issue Sep 28, 2020 · 2 comments
Assignees

Comments

@thomasyu888
Copy link
Member

thomasyu888 commented Sep 28, 2020

synapseformation currently only creates or retrieves entities. What should we do about "updating" entities. Lets say we specify FolderA for project, but then decide you want to rename it to FolderB. Would the client:

  • rename the old folder instead of creating a new one
  • delete the old folder and create a new one?
@BrunoGrandePhD
Copy link

If the entities are identified by name alone (e.g. FolderA) in the input schema, it might be impossible to update entities. I think supporting updates would require a more stable identifier with a separate name attribute that can be updated. Perhaps the stable identifier is stored as an annotation.

That said, how likely will users want to update existing entities? If the project hasn't started yet, it might be easier to manually nuke everything and re-create from scratch. And if the project has started, I would be reluctant to do anything other than carefully move/rename entities by hand.

@thomasyu888: Do you have use cases in mind for updating entities? If not, we can keep this issue around, but wait until use cases come up.

@thomasyu888
Copy link
Member Author

I don't currently have a usecase for updating entities. Although the way that the code is written currently makes its pretty difficult if generation of the template fails midway through.

@BrunoGrandePhD BrunoGrandePhD removed their assignment Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants