Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorListへのアクセスを正しく提供する #67

Open
coord-e opened this issue Aug 7, 2018 · 0 comments
Open

ErrorListへのアクセスを正しく提供する #67

coord-e opened this issue Aug 7, 2018 · 0 comments
Labels
refactoring Changes not in its behavior, but in the code

Comments

@coord-e
Copy link
Contributor

coord-e commented Aug 7, 2018

Step 1: 目的

  • event.error.onErrorがネットワークエラー専用になっている
  • store.error.addErrorを呼び出さざるを得ない(外界のeventにアクセスする手段がない場合もあるし)
  • しかし色んな所からstoreを呼ぶのはどうなの

Step 2: 概要

  • store.error.addErrorがいろいろなeventから呼ばれるのはしょうがない
  • エラーを表すクラスをつくる
  • いろいろなevent内でそのクラスのオブジェクトを作り、addErrorを呼ぶ
  • ネットワークエラーはちゃんとそう分かるようにevent.error.onErrorをrename
@coord-e coord-e added the refactoring Changes not in its behavior, but in the code label Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Changes not in its behavior, but in the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coord-e