Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid file glob in CMakeLists #19

Open
mknaranja opened this issue Mar 27, 2023 · 0 comments
Open

Avoid file glob in CMakeLists #19

mknaranja opened this issue Mar 27, 2023 · 0 comments
Labels
enhancement Improvement of current functionality good first issue Good for newcomers

Comments

@mknaranja
Copy link
Member

As The code line https://github.com/mknaranja/GMGPolar/blob/ddc23c2df1f424ced9a8c905f35dc43e8308bc3e/CMakeLists.txt#L6 is considered bad practice (https://stackoverflow.com/questions/32411963/why-is-cmake-file-glob-evil) we should go over to concrete list of files. However, this can be done easily without a lot of work by just using python to create folder lists:

import os
for file in os.listdir('src/test_cases'):
    print('X' + file)

We should then probably work with add_subdirectory that contain the corresponding CMakeLists.txt.

@mknaranja mknaranja added enhancement Improvement of current functionality good first issue Good for newcomers labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of current functionality good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant