Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused options / improve options #24

Open
mknaranja opened this issue Apr 2, 2023 · 1 comment
Open

Remove unused options / improve options #24

mknaranja opened this issue Apr 2, 2023 · 1 comment
Labels
enhancement Improvement of current functionality

Comments

@mknaranja
Copy link
Member

The current implementation has a lot of options (https://github.com/mknaranja/GMGPolar/blob/main/include/constants.h) refactored from the experimental Matlab code whose features where not refactored since only the most important and best working options have been transferred to C++. Unused options and all its references should be removed.

Among these options are:

  • origin_NOT_coarse
  • plotit (-> or better replace it by some option to export the solution in a meaningful format)
  • paraview

For the options, we should think of making use

  • solveit --> use it to define if compute_error() is executed?!

(To be extended)

@mknaranja mknaranja added the enhancement Improvement of current functionality label Apr 2, 2023
@mknaranja
Copy link
Member Author

At some point of the code, there are snippets "alt: ..." There an alternative option would need implementation. We should decide for each option if we do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of current functionality
Projects
None yet
Development

No branches or pull requests

1 participant