Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: No size example, two scale examples #2095

Closed
barbax7 opened this issue Dec 9, 2024 · 7 comments
Closed

[🐛 Bug]: No size example, two scale examples #2095

barbax7 opened this issue Dec 9, 2024 · 7 comments
Labels
bug Something isn't working needs-triaging

Comments

@barbax7
Copy link

barbax7 commented Dec 9, 2024

What happened?

I wanted to set the PaperSize property, reading documentation here :https://www.selenium.dev/documentation/webdriver/interactions/print_page/
But looking at example, the test_size function is identical to test_scale function: https://www.selenium.dev/documentation/webdriver/interactions/print_page/

How to set paper_size?

What browsers and operating systems are you seeing the problem on?

Firefox - windows

@barbax7 barbax7 added bug Something isn't working needs-triaging labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

@barbax7, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@yvsvarma
Copy link
Contributor

yvsvarma commented Jan 4, 2025

@barbax7 , This is addressed as part of #2118 . Please take a look and provide your feedback, Print Page

@barbax7
Copy link
Author

barbax7 commented Jan 4, 2025

Hi @yvsvarma , thank you for reply and for your PR.
I've read my first comment, i dont' understand why the two explaining url are equal, maybe i messed up something LOL.

I've looked at your code and the new webpage. I noticed that changes were made only for java, right? And not, for example, for python.

In java there is example with PaperSize
immagine

But in python, in Size section, there is again Scale examplee
immagine

@yvsvarma
Copy link
Contributor

yvsvarma commented Jan 5, 2025

Hi @barbax7 , I just fixed python example and submitted PR for review. Keep you posted on the update.

harsha509 added a commit that referenced this issue Jan 5, 2025
…ht and page_width (#2122)[deploy site]

Fix Python example for PrintOptions to address issue #2095

Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
selenium-ci added a commit that referenced this issue Jan 5, 2025
…ht and page_width (#2122)[deploy site]

Fix Python example for PrintOptions to address issue #2095

Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 215adae
@yvsvarma
Copy link
Contributor

yvsvarma commented Jan 6, 2025

Hi @barbax7 , My PR was merged, and page is now updated, Print Page. Please check let us know your feedback.

Thanks,
Vinay

@harsha509
Copy link
Member

HI @barbax7,

Thanks for pointing out the issue. We've corrected the code samples and the changes are now live.
Thank you @yvsvarma for picking this up!

Closing as resolved

@barbax7
Copy link
Author

barbax7 commented Jan 6, 2025

Hi @harsha509 , I hope my post was helpful in improving the documentation.
Thanks @yvsvarma for working on it.
Happy new year you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triaging
Projects
None yet
Development

No branches or pull requests

3 participants