Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying pipelines using a directory is non-deterministic #319

Open
Res260 opened this issue Jan 21, 2025 · 0 comments
Open

Specifying pipelines using a directory is non-deterministic #319

Res260 opened this issue Jan 21, 2025 · 0 comments

Comments

@Res260
Copy link
Contributor

Res260 commented Jan 21, 2025

With the introduction of #238 I introduced a non-deterministic behavior:

If multiple pipelines in the same directory have the same priority, the order in which they are applied is random. This is due to the usage of path.glob() which is non-deterministic https://stackoverflow.com/questions/6773584/how-are-glob-globs-return-values-ordered

The PySigma documentation specifies that Pipelines with the same priority are applied in the order they were provided. https://sigmahq-pysigma.readthedocs.io/en/latest/Processing_Pipelines.html

In this case, the applied order should, I think, be sorting by file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant