Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General Usage]: Snowflake Procedure should not require snowpark package version #3374

Open
sfc-gh-swinkler opened this issue Feb 3, 2025 · 1 comment
Labels
general-usage General help/usage questions

Comments

@sfc-gh-swinkler
Copy link
Collaborator

Terraform CLI Version

No response

Terraform Provider Version

No response

Company Name

No response

Terraform Configuration

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/procedure_python#snowpark_package-3

Snowflake Procedure currently requires this, but actually it is not required. Yes it needs to be passed with every request, but by default the version can be left unset. Take a look at the doc example here:


CREATE OR ALTER PROCEDURE python_add1(A NUMBER)
  RETURNS NUMBER
  LANGUAGE PYTHON
  HANDLER='main'
  RUNTIME_VERSION=3.10
  EXTERNAL_ACCESS_INTEGRATIONS=(example_integration)
  PACKAGES = ('snowflake-snowpark-python')
  EXECUTE AS OWNER
  AS
$$
def main(session, a):
    return a+1
$$;


i would also recommend adding some examples with snowpark package to the documentation for this resource.

Category

category:resource

Object type(s)

No response

Expected Behavior

N/A

Actual Behavior

N/A

Steps to Reproduce

N/A

How much impact is this issue causing?

Low

Logs

No response

Additional Information

No response

@sfc-gh-swinkler sfc-gh-swinkler added the general-usage General help/usage questions label Feb 3, 2025
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @sfc-gh-swinkler 👋
We had some issues with this implicit package (e.g., here), so we decided to take the safe approach of specifying the Snowpark version explicitly. We are planning to revisit it later and try to make the resource guess that the passed version is specified as latest. I think there were other issues than just not knowing the current Snowpark version, but I don't remember atm (we'll do a small research before the implementation part anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-usage General help/usage questions
Projects
None yet
Development

No branches or pull requests

2 participants