From b0d7dec20db509271011939f45ed060dadf3f9b8 Mon Sep 17 00:00:00 2001 From: Romain Goutte-Fangeas Date: Tue, 20 Feb 2024 11:24:18 +0100 Subject: [PATCH 1/2] Create button tertiary style --- .../compose/button/GrapesButtonColors.kt | 10 ++++++++++ .../button/GrapesButtonStyleDefaults.kt | 18 ++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonColors.kt b/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonColors.kt index 1cf4cf82..33d36f7f 100644 --- a/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonColors.kt +++ b/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonColors.kt @@ -35,6 +35,16 @@ object ButtonColorDefaults { disabledContentColor = GrapesTheme.colors.mainWhite ) + val tertiary: ButtonColors + @Composable + @ReadOnlyComposable + get() = GrapesButtonColors( + backgroundColor = GrapesTheme.colors.structureSurface, + contentColor = GrapesTheme.colors.primaryNormal, + disabledBackgroundColor = GrapesTheme.colors.structureSurface, + disabledContentColor = GrapesTheme.colors.neutralNormal, + ) + val text: ButtonColors @Composable @ReadOnlyComposable diff --git a/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonStyleDefaults.kt b/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonStyleDefaults.kt index d848bef7..9181e82a 100644 --- a/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonStyleDefaults.kt +++ b/library-compose/src/main/java/com/spendesk/grapes/compose/button/GrapesButtonStyleDefaults.kt @@ -94,6 +94,24 @@ object GrapesButtonStyleDefaults { isFillMaxWidthWithContent = false, ) + val tertiary: GrapesButtonStyle + @Composable + @ReadOnlyComposable + get() = GrapesButtonStyle( + textStyle = GrapesTheme.typography.titleL, + minSize = Size( + width = GrapesButtonDefaults.MinWidth.value, + height = GrapesButtonDefaults.MinHeight.value + ), + iconSize = GrapesButtonDefaults.iconSize, + shape = GrapesTheme.shapes.shape2, + rippleColor = GrapesTheme.colors.primaryLighter, + colors = ButtonColorDefaults.tertiary, + contentPadding = GrapesButtonDefaults.PaddingValues, + borderStroke = null, + isFillMaxWidthWithContent = true, + ) + val text: GrapesButtonStyle @Composable @ReadOnlyComposable From dc69433b00f1dd03883aac951cb445eeec57fc8a Mon Sep 17 00:00:00 2001 From: Romain Goutte-Fangeas Date: Tue, 20 Feb 2024 11:24:33 +0100 Subject: [PATCH 2/2] Fix GrapesStackItem design --- .../com/spendesk/grapes/compose/listitem/GrapesStackItem.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library-compose/src/main/java/com/spendesk/grapes/compose/listitem/GrapesStackItem.kt b/library-compose/src/main/java/com/spendesk/grapes/compose/listitem/GrapesStackItem.kt index 0ee00805..4cf6affb 100644 --- a/library-compose/src/main/java/com/spendesk/grapes/compose/listitem/GrapesStackItem.kt +++ b/library-compose/src/main/java/com/spendesk/grapes/compose/listitem/GrapesStackItem.kt @@ -42,7 +42,7 @@ object GrapesStackItemDefaults { fun colors( titleColor: Color = GrapesTheme.colors.neutralDarker, descriptionColor: Color = GrapesTheme.colors.neutralDarker, - backgroundColor: Color = GrapesTheme.colors.neutralLightest + backgroundColor: Color = GrapesTheme.colors.structureBackground ): GrapesStackItemColors = GrapesStackItemColors( titleColor = titleColor, descriptionColor = descriptionColor, @@ -73,7 +73,7 @@ fun GrapesStackItem( .then(clickableModifier) .background(colors.backgroundColor) .padding( - vertical = GrapesTheme.dimensions.spacing3, + vertical = GrapesTheme.dimensions.spacing2, horizontal = GrapesTheme.dimensions.spacing2, ), ) {