Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Configurable CredentialOfferState in createVciIssuerBuilder #148

Open
vijayshiyani opened this issue Dec 20, 2023 · 1 comment

Comments

@vijayshiyani
Copy link

vijayshiyani commented Dec 20, 2023

I was examining the createVciIssuerBuilder function in the functions.ts file at oid4vci-issuer package and noticed that it currently does not allow for a configurable CredentialOfferState. The function uses withInMemoryCredentialOfferState(), withInMemoryCNonceState(), and withInMemoryCredentialOfferURIState() which seems to set the states to an in-memory state.

builder.withInMemoryCredentialOfferState() .withInMemoryCNonceState() .withInMemoryCredentialOfferURIState()

However, in the OID4VCI repository, I noticed that there is a capability to support a custom implementation of the state manager.

Is the current implementation in createVciIssuerBuilder deliberate or is there a plan to allow for a configurable CredentialOfferState in the future?

Allowing a configurable CredentialOfferState would provide more flexibility for different use cases.

Looking forward to your response.

@nklomp
Copy link
Contributor

nklomp commented Jan 10, 2024

Yeah, that is something we will update. There is some refactor work on the low-level library coming up in which we will probably also simplify the state manager interface.

Before that we will have a look at whether it is simple to support custom CredentialOfferState. It mainly has to do with not really having other implementations yet and thus a bit of laziness ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants