Credential branding issues

[zpangrsic-eq]

There seems to be a bug with Credential Branding.

When we itterate over the credential branding as linked bellow

SSI-SDK/packages/oid4vci-holder/src/agent/OID4VCIHolder.ts

Line 753 in c41d295

const localeBranding: Array<IBasicCredentialLocaleBranding> | undefined = credentialBranding?.[credentialId]

the code here:

const localeBranding: Array<IBasicCredentialLocaleBranding> | undefined = credentialBranding?.[credentialId]

wants to find a object with key referencing the credentialId, but the

SSI-SDK/packages/oid4vci-holder/src/agent/OID4VCIHolderService.ts

Line 77 in c41d295

export const getCredentialBranding = async (args: GetCredentialBrandingArgs): Promise<Record<string, Array<IBasicCredentialLocaleBranding>>> => {

The above command is ran here in the OID4VCIHolder class:

SSI-SDK/packages/oid4vci-holder/src/agent/OID4VCIHolder.ts

Line 407 in c41d295

const credentialBranding = await getCredentialBranding({ credentialsSupported, context })

returns an Object containing types eg: UniversalCredential and not the credentialId.

[sanderPostma]

@zpangrsic-nchain
credential_configurations_supported entries do not have an id field anymore, so I assume you mean the map key of credential_configurations_supported.

{
  "credential_configurations_supported": {
    "UniversityDegreeCredential": {
      "format": "jwt_vc_json",
      "scope": "UniversityDegree",
      "cryptographic_binding_methods_supported": [
        "did:example"
      ],
      "credential_signing_alg_values_supported": [
        "ES256"
      ],
      "credential_definition": {
        "type": [
          "VerifiableCredential",
          "UniversityDegreeCredential"
        ],
        "credentialSubject": {
        ...

I see we have been using the type (!= VerifyableCredential) which is often equal to the id. I am leaning towards adding a mapBy: 'key' | 'type' arg to not break existing implementations, but I will need to discuss internally.