Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies in library #136

Open
RickMoynihan opened this issue Dec 17, 2021 · 0 comments
Open

Fix dependencies in library #136

RickMoynihan opened this issue Dec 17, 2021 · 0 comments

Comments

@RickMoynihan
Copy link
Member

RickMoynihan commented Dec 17, 2021 •
edited
Loading

As table2qb uses lein-tools-deps it destroys the real dependency subtree.

Additionally the deps expose dependencies like Log4j2 when consumed as a library.

In particular this is relevant to stuff like https://github.com/Swirrl/pmd-pipelines/ which consumes this as a library.

We should stop using lein-tools-deps and migrate to a system using tools.build for building the table2qb app and publishing the table2qb libraries respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RickMoynihan