Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webextension Regression] - Attachment "Save all" applies only to orginal attachments #105

Open
dugite-code opened this issue Jul 17, 2023 · 10 comments
Labels
bug Something isn't working upstream Designated as an upstream issue
Milestone

Comments

@dugite-code
Copy link
Collaborator

This was a regression introduced with the migration to webextension. When selecting the Save All button for attachments only the winmail.dat and other original attachments are saved. Users currently must drag and drop files or open the containing folder to access files.

@dugite-code dugite-code added the bug Something isn't working label Jul 17, 2023
@dugite-code dugite-code added this to the 6.1 milestone Jul 17, 2023
@dugite-code dugite-code pinned this issue Jul 17, 2023
@jobisoft
Copy link
Collaborator

I think I will fix this in core directly, together with the work to add the Attachments API used by lookout fixed. ETA: 1 month.

@nckramer
Copy link

nckramer commented Oct 6, 2023

thank you. and apologies for the duplicate. the "open" is a good workaround.

@dugite-code
Copy link
Collaborator Author

@jobisoft has there been any changes upstream so far with this?

@jobisoft
Copy link
Collaborator

It is on track for the next ESR.

@AndyM48
Copy link

AndyM48 commented Mar 3, 2024

Is this the same error as - highlight file > select Save As > locate folder and Save - nothing is saved?

@nckramer
Copy link

nckramer commented Mar 3, 2024

Yes. The temporary workaround is use "open" or "open all" when prompted what to do with the files, choose "save", pick a location, and check the box for always do the same thing.

You still get the same result. The files are extracted & saved. Just the method is a little different.

@davidmorr
Copy link

I think I this problem still exists, but perhaps in a slightly different form to the original bug above.

macOS 12.7.6 on Mac Mini M1, Thunderbird 115.18.0 (64-bit)

If I double-click the attachment name at the bottom of the message window, the attachment opens in an appropriate application (Preview for PDF, TextEdit for RTF, etc). I can then select Save As... in the app and save a full copy.

If I select Show in Finder, the full file is in this folder:
/private/var/folders/vx/cd13wgwd5_nd24r4jl2xp2480000gn/T

Clicking Save All button does nothing at all afaics.

(Right click)|Save As... on an attachment puts up a file dialogue with the correct name, but clicking Open leaves nothing in the selected folder.

Click and drag the attachment name will create a file where it is dragged to, but it is zero length. (This is the main way many Mac users extract attachments to save in specific locations. It is particularly treacherous that it seems to create a file which may leave people thinking they have saved a copy of the attachment.)
So while it is possible to get the attachment, most methods people are likely to want to use do not work.

I found this in the Error Console:
LookOut errors.txt

@nckramer
Copy link

The only workaround, although un-intuitive is to "open all". (same spot as "save all") There is no dialog box, save box etc. It just dumps the attached files to your desktop or designated "save to" spot.
All other ways to save attachments out of these Microsoft emails is still broken.

@davidmorr
Copy link

davidmorr commented Jan 11, 2025

Open All just opens them all, same as double-clicking on the individual filenames. It does not leave them in Downloads or on the desktop.

In the General settings pane, if you set Files & Attachments to Save Files for a file type, double-clicking just dumps the file into Downloads. It also changes the action of Right-click|Open to dump the file in Downloads.

So a possible workaround, although inconvenient for all the ordinary attachments.

I wonder whether the bug is in how LookOut interacts with that setting?

The most satisfactory workaround is to set it to "Always Ask" for each file type you get in the winmail.dat. It then asks whether to open or save and appears to do the right thing, ie, open or save. Bit of a nuisance for all the ordinary attachment file types.

@nckramer
Copy link

@davidmorr - it can save all files instead of opening them. it's quicker & less hassle. but yes, it needs setup a certain way.

  • choose "save file" instead of "open with", and "do this automatically"
    once you've done this with all the file types you get, when you select "open all" it will just save all the files to the designated location. or you can set your preferences in settings, or change it back to "always ask" if you don't want to automatically save them anymore.
    Screen-Shot-2025-01-12-at-1 03 36-PM
    Screen-Shot-2025-01-12-at-1 01 26-PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Designated as an upstream issue
Projects
None yet
Development

No branches or pull requests

5 participants