Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add-on Compatability] FiltaQuilla Header Regex conflict #116

Open
xlovinglyx opened this issue Mar 29, 2024 · 9 comments
Open

[Add-on Compatability] FiltaQuilla Header Regex conflict #116

xlovinglyx opened this issue Mar 29, 2024 · 9 comments
Labels
need more information Further information is requested Papercut Minor issue - Low Priority

Comments

@xlovinglyx
Copy link

xlovinglyx commented Mar 29, 2024

BUG (The pipe)

Hi Oleksandr & Dugite-Code,

lookout+ generates bugs in filtaquilla extension.

it turns the "Sender:" argument into "From:"
Personally, i prefer from, cause it's how it's presented
in the mime field, but the major bug, that appears in
filtaquilla which requires a fix, is that all my filtaquilla based
regex filters in thunderbird, now only work if i add
a pipe symbol (vertical line) at the end of
my regular expressions.

Please fix that.

@xlovinglyx
Copy link
Author

xlovinglyx commented Mar 30, 2024

Also stated by Filtaquilla's coder:

RealRaven2000/FiltaQuilla#257

@dugite-code
Copy link
Collaborator

dugite-code commented Apr 2, 2024

Hi,
We have made a very specific design decision with lookout to not modify emails in any way. The modifications done are on-the-fly for display purposes and only relate to attachments at this time, I can't see where Lookout might interfere with any searching patterns related to the email headers.

I'm not clear what that regex is trying to achieve as I don't personally use Filtaquilla myself. Your issues may be caused by the actual email itself as if it's a Microsoft TNEF email it doesn't really follow common standards.

If you can provide any logs pointing to Lookout causing this issue, please feel free to update

@dugite-code dugite-code added wontfix This will not be worked on Invalid An invalid issue labels Apr 2, 2024
@stale stale bot removed the wontfix This will not be worked on label Apr 2, 2024
@dugite-code dugite-code added the wontfix This will not be worked on label Apr 2, 2024
@xlovinglyx
Copy link
Author

"I can't see where Lookout might interfere with any searching patterns related to the email headers."
"I'm not clear what that regex is trying to achieve as I don't personally use Filtaquilla myself. "

To see it, you'd have to try the addon.

It's simple: i've made tests with filtaquilla, using header regex match:
Sender:/[.-*«"“ #]{0,13}anythingy[.-*"”» #]{0,13}</gmi
& it works to del emails containing anythingy as the email sender name..

Now.... if i keep your lookout+ addon installed......
From:[.-*«"“#]{0,13}anythingy[.-*"”» #]{0,13}<|

New: From instead of Sender argument works.. . "filtaquilla's maintainer confirms i shouldn't be able to use "From"
& also adds that he doesn't know WHY my filter works ONLY if i add a pipe in the end, which is:
THE ONLY WAY I CAN MAKE MY FILTER WORK if i have "lookout+" installed.
all other addons are not interfering,

@xlovinglyx
Copy link
Author

Try to localize that pipe & avoid interference with filtaquilla please, otherwise, i'll sadly be compelled to forever avoid
lookout+. as my regex formats are correct & functional only when lookout+ is uninstalled.

@dugite-code
Copy link
Collaborator

If I get the time I might look at it, but I would suggest that you'll have to find a way to provide some debug logs or direction because as it stands I'm not sure where to even start.

@dugite-code
Copy link
Collaborator

Incidentally you keep saying Lookout+ this is a defunct fork of the original project that is no longer updated. I presume you mean LookOut (fix-version)

@dugite-code dugite-code added need more information Further information is requested and removed wontfix This will not be worked on Invalid An invalid issue labels Apr 4, 2024
@xlovinglyx
Copy link
Author

lookout fix version i mean.

you don't know where to start ?
i gave you the regular expression used.. telling u it works fine without ur addon installed..

"If I get the time I might look at it, but I would suggest that you'll have to find a way to provide some debug logs or direction because as it stands I'm not sure where to even start."

i'm not a programmer, how do u want me to do that ?

@dugite-code
Copy link
Collaborator

Well I'm just a volunteer maintainer so my time is limited to work on this project. Any assistance in reducing the work needed to find a bug is appreciated. The information you have supplied so far quite shallow and is the technical equivalent of saying there is a needle somewhere in a haystack.

You'll want to monitor the console outputs and attempt to narrow down the trigger conditions as much as possible https://developer.thunderbird.net/add-ons/tips-and-tricks#debugging

That said inter add-on compatibility is a low priority issue for me at this time.

@xlovinglyx
Copy link
Author

  1. The information you have supplied so far quite shallow and is the technical equivalent of saying there is a needle somewhere in a haystack. < If i was a programmer, agreed.
  2. You'll want to monitor the console outputs and attempt "to narrow down the trigger conditions as much as possible" < if i knew the language, agreed.
  3. That said inter add-on compatibility is a low priority issue for me at this time. < Not worried, i found a better fix, Time to dump & uninstall lookout for good.
  4. As you can see, i have other priorities & better things to do than helping coders with languages i know nothing about.

long life to lookout "fix", but for the sanity of my actual addons, it'll be out of my life now.

@dugite-code dugite-code changed the title Lookout+ generating bugs in Filtaquilla [Add-on Compatability] FiltaQuilla Header Regex conflict Apr 11, 2024
@dugite-code dugite-code added the Papercut Minor issue - Low Priority label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more information Further information is requested Papercut Minor issue - Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants