Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display attachements inline #15

Open
honsberg opened this issue Sep 5, 2018 · 3 comments
Open

display attachements inline #15

honsberg opened this issue Sep 5, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@honsberg
Copy link

honsberg commented Sep 5, 2018

Feature request:
after opening an message with winmail.dat and lookout decoding it, display the attachements (images, html) inline in message body.

@dugite-code dugite-code added the enhancement New feature or request label Sep 7, 2018
@dugite-code
Copy link
Collaborator

Might be able to get this working after I re-architecture the add-on. I'll need to do some research into better ways of handling the attachments.

@dugite-code
Copy link
Collaborator

dugite-code commented Sep 10, 2018

Dev Notes


  • Attachments are not *real* they are virtual place-holders.
  • Attachments are currently processed asynchronously changes in attachment-rework branch breaks that (?) Could cause performance issues.
  • Temporary files and attachment names don't match. Need some message unique subfolder in temporary directory.
  • Message view re-load to allow inline view need to be researched.
  • Calendar direct access breaks because custom save/open functions are currently disabled.
  • rescue conflicting alternatives might be an example of how to go about this. Re-build the message and replace it inline

@dugite-code dugite-code added the help wanted Extra attention is needed label Sep 10, 2018
@dugite-code
Copy link
Collaborator

dugite-code commented Oct 10, 2018

I did ask for advice on the Thunderbird discourse, however I have yet to receive any feedback. https://discourse.mozilla.org/t/update-inline-attachments-view/31671

Additional Notes:

This looks like the image inline attachment logic in source:
https://dxr.mozilla.org/comm-central/source/comm/suite/mailnews/msgHdrViewOverlay.js?q=msgHdrViewOverlay.js&redirect_type=direct#613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants