Skip to content

Commit 59c90dd

Browse files
authored
[FEATURE] Merge pull request #16 from menoliu/update-syntax
Fixes bug for reading `pre` and `noe` data files
2 parents 0897699 + 7923979 commit 59c90dd

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

CHANGELOG.rst

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Changelog
33
=========
44

5+
* Update syntax for NOE and PRE experimental values from ``value`` to ``dist_value``
6+
57
v0.1.5 (2024-11-19)
68
------------------------------------------------------------
79

src/xeisd/components/__init__.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
exp_idx = 'index'
1010
exp_resnum = 'resnum'
1111
exp_val = 'value'
12+
exp_dist_val = 'dist_value'
1213
exp_max = 'upper'
1314
exp_atmID = 'atomname'
1415
exp_min = 'lower'
@@ -80,9 +81,9 @@
8081

8182
XEISD_TITLE = (
8283
"\n _ _ ____ ____ ___ ____ \n" # noqa: W605
83-
"( \/ )___( ___)(_ _)/ __)( _ \ \n" # noqa: W605
84-
" ) ((___))__) _)(_ \__ \ )(_) )\n" # noqa: W605
85-
"(_/\_) (____)(____)(___/(____/ \n" # noqa: W605
84+
"( \\/ )___( ___)(_ _)/ __)( _ \\ \n" # noqa: W605
85+
" ) ((___))__) _)(_ \\__ \\ )(_) )\n" # noqa: W605
86+
"(_/\\_) (____)(____)(___/(____/ \n" # noqa: W605
8687
"================================="
8788
)
8889

src/xeisd/components/parser.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
cs_name,
7979
default_bc_errors,
8080
exp_atmID,
81+
exp_dist_val,
8182
exp_err,
8283
exp_idx,
8384
exp_max,
@@ -218,7 +219,7 @@ def parse_nmrstar_data(fpath, type=None):
218219
lower.append(float(min))
219220

220221
if type == noe_name or type == pre_name:
221-
return pd.DataFrame({exp_idx: index, exp_val: values, exp_max: upper, exp_min: lower, exp_err: errors}) # noqa: E501
222+
return pd.DataFrame({exp_idx: index, exp_dist_val: values, exp_max: upper, exp_min: lower, exp_err: errors}) # noqa: E501
222223
return pd.DataFrame({exp_idx: index, exp_val: values, exp_err: errors})
223224

224225

@@ -317,6 +318,8 @@ def parse_data(filenames, mode, bc_errors=default_bc_errors):
317318
try:
318319
with open(filenames[module], 'r') as f:
319320
raw = json.load(f)
321+
if module == pre_name or module == noe_name:
322+
del raw['format']
320323
if isinstance(list(raw.items())[0][1], float):
321324
data = pd.DataFrame(raw, index=[0]).T
322325
else:

src/xeisd/components/scorers.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from xeisd.components import (
1111
cs_name,
1212
exp_atmID,
13+
exp_dist_val,
1314
exp_err,
1415
exp_idx,
1516
exp_max,
@@ -332,7 +333,7 @@ def noe_optimization_ensemble(
332333
new_index=None,
333334
):
334335
"""Logic for NOE scoring."""
335-
exp_distance = exp_data[noe_name].data[exp_val].values
336+
exp_distance = exp_data[noe_name].data[exp_dist_val].values
336337

337338
# Either `upper,lower` or `error` is required for exp_sigma
338339
try:
@@ -380,7 +381,7 @@ def pre_optimization_ensemble(
380381
):
381382
"""Logic for PRE scoring function."""
382383
# prepare data
383-
exp_distance = exp_data[pre_name].data[exp_val].values
384+
exp_distance = exp_data[pre_name].data[exp_dist_val].values
384385
# Either `upper,lower` or `error` is required for exp_sigma
385386
try:
386387
upper_bound_value = exp_data[pre_name].data[exp_max].values

0 commit comments

Comments
 (0)