Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination button image gallery #1111

Closed
MadsNyl opened this issue Sep 30, 2024 · 0 comments · Fixed by #1145
Closed

Pagination button image gallery #1111

MadsNyl opened this issue Sep 30, 2024 · 0 comments · Fixed by #1145
Assignees
@Josefinegh
Labels
good first issue Good for newcomers refactor Refactor of old code without functional change

Comments

@MadsNyl
Copy link
Contributor

MadsNyl commented Sep 30, 2024

Refactor suggestion

The "Last inn mer" pagination button is inside the loop of the images in the gallery. The button should be below the images.

image
@MadsNyl MadsNyl added good first issue Good for newcomers refactor Refactor of old code without functional change labels Sep 30, 2024
@Josefinegh Josefinegh mentioned this issue Oct 21, 2024
Merged
3 tasks
@Josefinegh Josefinegh linked a pull request Oct 21, 2024 that will close this issue
Refactor(gallery)/move pagination button below pictures #1145
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Josefinegh Josefinegh

Labels
good first issue Good for newcomers refactor Refactor of old code without functional change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor(gallery)/move pagination button below pictures TIHLDE/Kvark
2 participants
@MadsNyl @Josefinegh