From 71970303285b8584408dffe0337af5fef76926ca Mon Sep 17 00:00:00 2001 From: wwwcg Date: Fri, 13 Sep 2024 20:25:36 +0800 Subject: [PATCH] fix(ios): avoid startup crash when script load error --- framework/ios/base/bridge/HippyBridge.mm | 3 ++- renderer/native/ios/renderer/HippyRootView.mm | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/framework/ios/base/bridge/HippyBridge.mm b/framework/ios/base/bridge/HippyBridge.mm index df7dea8be9b..dce46f6fc5a 100644 --- a/framework/ios/base/bridge/HippyBridge.mm +++ b/framework/ios/base/bridge/HippyBridge.mm @@ -589,7 +589,8 @@ - (void)beginLoadingBundle:(NSURL *)bundleURL if (!strongSelf || !strongSelf.valid || !script) { NSString *errMsg = [NSString stringWithFormat:@"Bundle Execution Operation Fail! valid:%d, script:%@", strongSelf.valid, script]; - completion(nil, HippyErrorWithMessage(errMsg)); + HippyLogError(@"%@", errMsg); + completion(bundleURL, HippyErrorWithMessage(errMsg)); strongSelf.lastExecuteOperation = nil; return; } diff --git a/renderer/native/ios/renderer/HippyRootView.mm b/renderer/native/ios/renderer/HippyRootView.mm index d08fed7628a..f140a9a869f 100644 --- a/renderer/native/ios/renderer/HippyRootView.mm +++ b/renderer/native/ios/renderer/HippyRootView.mm @@ -185,7 +185,7 @@ - (instancetype)initWithBridge:(HippyBridge *)bridge } // 抛出业务包(BusinessBundle aka SecondaryBundle)加载完成通知，for hippy2兼容 - NSMutableDictionary *userInfo = @{ kHippyNotiBundleUrlKey: url, + NSMutableDictionary *userInfo = @{ kHippyNotiBundleUrlKey: url ?: @"", kHippyNotiBridgeKey: strongSelf.bridge }.mutableCopy; if (error) { [userInfo setObject:error forKey:kHippyNotiErrorKey]; } HIPPY_IGNORE_WARNING_BEGIN(-Wdeprecated)