fix(core): ids facet bounds checking was inverted

HoyosJuan · HoyosJuan · commit 2c7461ff5a4d · 2025-02-03T22:25:36.000-05:00
diff --git a/packages/core/src/openbim/IDSSpecifications/src/facets/Facet.ts b/packages/core/src/openbim/IDSSpecifications/src/facets/Facet.ts
@@ -84,11 +84,11 @@ export abstract class IDSFacet {
       let maxPass = true;
 
       if (min !== undefined) {
-        minPass = minInclusive ? value <= min : value < min;
+        minPass = minInclusive ? value >= min : value > min;
       }
 
       if (max !== undefined) {
-        maxPass = maxInclusive ? value >= max : value > max;
+        maxPass = maxInclusive ? value <= max : value < max;
       }
 
       pass = minPass && maxPass;

Original file line number	Diff line number	Diff line change
`@@ -84,11 +84,11 @@ export abstract class IDSFacet {`
`84`	`84`	`let maxPass = true;`
`85`	`85`
`86`	`86`	`if (min !== undefined) {`
`87`		`- minPass = minInclusive ? value <= min : value < min;`
	`87`	`+ minPass = minInclusive ? value >= min : value > min;`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`if (max !== undefined) {`
`91`		`- maxPass = maxInclusive ? value >= max : value > max;`
	`91`	`+ maxPass = maxInclusive ? value <= max : value < max;`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`pass = minPass && maxPass;`