Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct swing commands for Hitachi models #165

Open
octal-ip opened this issue Jan 13, 2024 · 2 comments
Open

Correct swing commands for Hitachi models #165

octal-ip opened this issue Jan 13, 2024 · 2 comments

Comments

@octal-ip
Copy link
Contributor

octal-ip commented Jan 13, 2024

There are a few minor mistakes in HitachiHeatpumpIR.cpp that prevent the vertical and horizontal swing functions from operating. The corrected code block is below, starting from line 83:

  switch (swingVcmd)
  {
    case VDIR_AUTO:
      swingV = HITACHI_AIRCON1_VDIR_AUTO;
      break;
    case VDIR_SWING:
      swingV = HITACHI_AIRCON1_VDIR_SWING;
      break;
  }

  switch (swingHcmd)
  {
    case HDIR_AUTO:
      swingH = HITACHI_AIRCON1_HDIR_AUTO;
      break;
    case HDIR_SWING:
      swingH = HITACHI_AIRCON1_HDIR_SWING;
      break;
  }
@ToniA
Copy link
Owner

ToniA commented Jan 13, 2024

Hi, would you create a pull request? I will then merge and release it. Thanks!

@octal-ip
Copy link
Contributor Author

octal-ip commented Apr 3, 2024

Pull request created.

ToniA added a commit that referenced this issue Apr 6, 2024
Corrected swingVcmd and swingHcmd to address issue #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants