Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Fabric.InternetNAT should have a zero value of true #140

Open
jwreagor opened this issue Mar 27, 2018 · 3 comments
Open

network: Fabric.InternetNAT should have a zero value of true #140

jwreagor opened this issue Mar 27, 2018 · 3 comments
Labels

Comments

@jwreagor
Copy link
Contributor

Ref: terraform-providers/terraform-provider-triton#100

It's up for debate whether or not we should also create a fabric network with internet NAT by default from within triton-go. CloudAPI says it defaults to true but I'm not certain if that means we can simply omitempty for the field and let CloudAPI create the internet NAT, or if that's even viable with our current Network.Fabric.Create API and lack of zero value handling.

Either way, we should explore treating this identical to CloudAPI.

@kwilczynski
Copy link
Contributor

Related to #122.

@jen20
Copy link
Contributor

jen20 commented Mar 27, 2018

The reason this was different in the first place (certainly in Terraform, and likely here too as a result) is that you couldn't delete a NAT once it exists without support input. If this is still the case I am heavily in favour of leaving this alone.

@twhiteman
Copy link
Contributor

NAT zones are now cleaned up when there are no more consumers of that NAT - i.e. when the last VM using the NAT is deleted, then the NAT is also deleted.

c.f. https://smartos.org/bugview/NAPI-258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants