Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom geoms #16

Open
mps9506 opened this issue Jun 22, 2023 · 1 comment
Open

custom geoms #16

mps9506 opened this issue Jun 22, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mps9506
Copy link
Contributor

mps9506 commented Jun 22, 2023

Instead of a plotting function that exports the ggobject, the fdc/ldc layers can be created using a custom geom. This retains the expected ggplot workflow that everyone uses. I think this should be the preferred way of creating plots. See:
https://fosstodon.org/@milesmcbain/110587249315649714

@mps9506 mps9506 added the enhancement New feature or request label Jun 22, 2023
@mps9506 mps9506 self-assigned this Jun 22, 2023
@mps9506
Copy link
Contributor Author

mps9506 commented Jun 22, 2023

Spitballing how this would look:

ggplot() +
  geom_ldc(data = df_ldc, aes(P_Exceedance, Allowable_Daily_Load)) +
  geom_ldc_sum(data = df_sum, aes(Median_P, Median_Flow_Load)) +
  labs(y = "whatever", x = "exceedance")

Instead of geom_ldc_sum() we could make use of stat_summary() which opens up the possibility to overlay mean, median, boxplots, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant