Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Standard: use data-cy= instead of id= attr in test.html #12

Open
Madoshakalaka opened this issue Nov 18, 2020 · 0 comments
Open

Code Standard: use data-cy= instead of id= attr in test.html #12

Madoshakalaka opened this issue Nov 18, 2020 · 0 comments

Comments

@Madoshakalaka
Copy link
Collaborator

test.html is only used in cypress testing. id= has been used for cypress to grab dom elements, an example here:

  <span id="test1">wâpamêw</span> <br>
  <span id="English1">hello</span>

We should really do

  <span data-cy="test1">wâpamêw</span> <br>
  <span data-cy="English1">hello</span>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Madoshakalaka