Skip to content

Feedback from Joel #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9 of 10 tasks
joelostblom opened this issue Mar 6, 2025 · 3 comments
Open
9 of 10 tasks

Feedback from Joel #54

joelostblom opened this issue Mar 6, 2025 · 3 comments

Comments

@joelostblom
Copy link

joelostblom commented Mar 6, 2025

Implement two major and two minor

Major:

  • Make it look more like a dashboard and less like a webpage with text and charts on a white background
  • Add additional line chart of modes over time in bottom right corner

Minor:

  • Figure out if colorscale should be fixed over the entire range or to the filtered data only
  • Remove "Total" category from bar chart with everything selected
  • Remove "Weighted" from avg title
  • Change text of violing plot to legend?
  • Consider swtich x and y on bar chart
  • Text at the bottom should not be one long sentence
  • Slider should not go outside the main dashboard
  • Fix layout issues where map and bar chart are a bit overlapping at different width.
@derekrodgers
Copy link
Collaborator

derekrodgers commented Mar 6, 2025

Make it look more like a dashboard and less like a webpage with text and charts on a white background

  • Make title and widgets section a different colour
  • Add colour background to map? <-- this looks terrible
  • Get rid of explanatory text on violin
  • Explore adding margins around charts, or whatever might help distinguish them visually

@derekrodgers
Copy link
Collaborator

derekrodgers commented Mar 7, 2025

Most of the above issues have been addressed in this PR.

@derekrodgers
Copy link
Collaborator

We are going to revisit this one in M4:

Figure out if colorscale should be fixed over the entire range or to the filtered data only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants