New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_grassland_remaining_proxy.py #43

Open

burnettear opened this issue Jan 22, 2025 · 1 comment

Assignees

Collaborator

burnettear commented Jan 22, 2025

Code review of file task_grassland_remaining_proxy.py

Good:

Input and output data files are present at specified filepaths
Units and formatting of output data is compliant
Header comment has added and made compliant
Comments explain data operations
Function docstrings describe function inputs, outputs

Improvements:

Header added to be compliant
Unnecessary library imports removed
Output uses 'rel_emi' and removes lat/lon
Next version: Use pytask

TODO:

@ccoxen See TODO comments here in the code review branch.
Review updated comments and documentation, and approve.
Consider re-running code to update proxy file to have 'rel_emi' column

burnettear assigned ccoxen

Collaborator Author

burnettear commented Jan 27, 2025

https://github.com/USEPA/GEPA/blob/code_review_2024-12/gch4i/proxy_processing/grassland_remaining_proxy.py

Corrected link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment