New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_pop_proxy.py #53

Open

burnettear opened this issue Jan 27, 2025 · 1 comment

Assignees

Collaborator

burnettear commented Jan 27, 2025

Code review of file task_pop_proxy.py

Good:

Header comment has added and made compliant
Good code structure
Efficient processing

Improvements:

Header added to be compliant
Recommend adding function docstrings to briefly explain function process/output. Since functions are imported from gch4i.utils, reader may not understand what script is doing.

TODO:

@nkruskamp See TODO comments here in the code review branch.
Consider adding brief function docstrings.

burnettear assigned nkruskamp

Collaborator Author

burnettear commented Jan 27, 2025

https://github.com/USEPA/GEPA/blob/code_review_2024-12/gch4i/proxy_processing/task_pop_proxy.py

Corrected. link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment